Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator historical state restoration #922

Merged
merged 71 commits into from
Dec 14, 2024

Conversation

marcinczenko
Copy link
Contributor

@marcinczenko marcinczenko commented Sep 26, 2024

At the moment the validator has started, there may already be existing active storage requests containing slots with slot ids that should be monitored by the validator: these are slot ids that either belong to the group observed by the validator or basically any slot id if validator is to monitor the whole slot id space.

In this context we want the validator to find and monitor all those slots id associated with storage requests that started earlier and have not yet concluded.

For more details, please refer to the discussion in #458.

@marcinczenko marcinczenko added Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details WIP Work in Progress (but open to comments) labels Sep 26, 2024
@marcinczenko marcinczenko self-assigned this Sep 26, 2024
@marcinczenko marcinczenko marked this pull request as draft September 26, 2024 14:28
@marcinczenko marcinczenko removed the WIP Work in Progress (but open to comments) label Sep 26, 2024
@marcinczenko marcinczenko changed the base branch from master to validator-partitioning-slotid-space September 26, 2024 18:09
@marcinczenko marcinczenko force-pushed the validator-partitioning-slotid-space branch from 3b4a7fe to 89738ff Compare October 1, 2024 02:15
@marcinczenko marcinczenko force-pushed the validator-historical-state branch from 9e9882b to 6879c27 Compare October 1, 2024 02:22
@marcinczenko marcinczenko force-pushed the validator-partitioning-slotid-space branch 3 times, most recently from fc34613 to 1459644 Compare October 2, 2024 20:20
Base automatically changed from validator-partitioning-slotid-space to master October 2, 2024 23:09
@marcinczenko marcinczenko force-pushed the validator-historical-state branch 3 times, most recently from 92b6e96 to 7b20c4b Compare October 9, 2024 01:58
@marcinczenko marcinczenko force-pushed the validator-historical-state branch 2 times, most recently from 77fcad2 to 4df6a21 Compare October 14, 2024 23:12
@marcinczenko marcinczenko marked this pull request as ready for review October 15, 2024 01:28
@marcinczenko marcinczenko force-pushed the validator-historical-state branch 4 times, most recently from 7e06bd8 to 165d514 Compare October 18, 2024 03:14
@marcinczenko
Copy link
Contributor Author

The reason for occasional integration tests failure on Windows is described in codex-storage/nim-ethers#79.

@marcinczenko marcinczenko force-pushed the validator-historical-state branch from 98e3378 to a91c76f Compare November 24, 2024 23:56
Copy link
Contributor

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Marcin, thank you. It took me quite a few hours to review this PR. In the future, any kind of split up of the work (into separate PRs) would be much appreciated!

tests/integration/multinodes.nim Show resolved Hide resolved
codex/contracts/market.nim Outdated Show resolved Hide resolved
codex/contracts/market.nim Outdated Show resolved Hide resolved
codex/contracts/market.nim Outdated Show resolved Hide resolved
codex/contracts/market.nim Outdated Show resolved Hide resolved
tests/integration/testvalidator.nim Outdated Show resolved Hide resolved
tests/integration/testvalidator.nim Outdated Show resolved Hide resolved
tests/integration/testvalidator.nim Outdated Show resolved Hide resolved
tests/integration/testvalidator.nim Outdated Show resolved Hide resolved
tests/integration/marketplacesuite.nim Outdated Show resolved Hide resolved
@marcinczenko marcinczenko force-pushed the validator-historical-state branch from 0a30384 to a43e1e0 Compare December 13, 2024 15:41
@marcinczenko marcinczenko added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 13, 2024
@marcinczenko marcinczenko added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 13, 2024
@marcinczenko marcinczenko added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 14, 2024
@veaceslavdoina veaceslavdoina added this pull request to the merge queue Dec 14, 2024
Merged via the queue into master with commit 92a0eda Dec 14, 2024
17 checks passed
@veaceslavdoina veaceslavdoina deleted the validator-historical-state branch December 14, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator needs to reconstruct its state from historical blockchain data
5 participants